Parcourir la source

server browsering controller: fix runtime exception

SubtitleType is an optional part of the protocol, so it may not be called blindly.
Felix Paul Kühne il y a 6 ans
Parent
commit
f0bb2911e8
1 fichiers modifiés avec 8 ajouts et 2 suppressions
  1. 8 2
      SharedSources/ServerBrowsing/VLCServerBrowsingController.m

+ 8 - 2
SharedSources/ServerBrowsing/VLCServerBrowsingController.m

@@ -286,8 +286,14 @@
     NSString *FileSubtitlePath = nil;
     NSURL *subtitleURL = item.subtitleURL;
     NSString *extension = [subtitleURL pathExtension];
-    if ([extension isEqualToString:@""])
-        extension = item.subtitleType;
+    if ([extension isEqualToString:@""]) {
+        if ([item respondsToSelector:@selector(subtitleType)]) {
+            extension = item.subtitleType;
+        } else {
+            /* insert a generic subtitle file extension here because otherwise the file would be lost */
+            extension = @"sub";
+        }
+    }
 
     filename = [NSString stringWithFormat:@"%@.%@", [filename stringByDeletingPathExtension], extension];