Browse Source

EditToolbar: Add accessibility to buttons

Soomin Lee 6 years ago
parent
commit
f07326c276
2 changed files with 14 additions and 1 deletions
  1. 6 0
      Resources/en.lproj/Localizable.strings
  2. 8 1
      Sources/EditToolbar.swift

+ 6 - 0
Resources/en.lproj/Localizable.strings

@@ -303,6 +303,7 @@
 
 //EDIT
 "ADD_TO_PLAYLIST" = "Add to Playlist";
+"ADD_TO_PLAYLIST_HINT" = "Open the add to playlist menu";
 
 "PLAYLIST_PLACEHOLDER" = "Playlist title";
 "PLAYLIST_DESCRIPTION" = "Choose a title for your new playlist";
@@ -315,6 +316,11 @@
 "ERROR_RENAME_FAILED" = "Renaming failed";
 "ERROR_EMPTY_NAME" = "The title can't be empty";
 
+"SHARE_LABEL" = "Share";
+"SHARE_HINT" = "Share selected files";
+"RENAME_HINT" = "Rename selected files";
+"DELETE_HINT" = "Delete selected files";
+
 // Sort
 
 "HEADER_TITLE_SORT" = "Sort by";

+ 8 - 1
Sources/EditToolbar.swift

@@ -27,6 +27,8 @@ class EditToolbar: UIView {
         shareButton.setImage(UIImage(named: "share"), for: .normal)
         shareButton.tintColor = .orange
         shareButton.widthAnchor.constraint(equalToConstant: 44).isActive = true
+        shareButton.accessibilityLabel = NSLocalizedString("SHARE_LABEL", comment: "")
+        shareButton.accessibilityHint = NSLocalizedString("SHARE_HINT", comment: "")
         return shareButton
     }()
     private var renameButton: UIButton = {
@@ -35,6 +37,8 @@ class EditToolbar: UIView {
         renameButton.setImage(UIImage(named: "rename"), for: .normal)
         renameButton.tintColor = .orange
         renameButton.widthAnchor.constraint(equalToConstant: 44).isActive = true
+        renameButton.accessibilityLabel = NSLocalizedString("BUTTON_RENAME", comment: "")
+        renameButton.accessibilityHint = NSLocalizedString("RENAME_HINT", comment: "")
         return renameButton
     }()
     private var deleteButton: UIButton = {
@@ -43,7 +47,8 @@ class EditToolbar: UIView {
         deleteButton.setImage(UIImage(named: "delete"), for: .normal)
         deleteButton.tintColor = .orange
         deleteButton.widthAnchor.constraint(equalToConstant: 44).isActive = true
-
+        deleteButton.accessibilityLabel = NSLocalizedString("BUTTON_DELETE", comment: "")
+        deleteButton.accessibilityHint = NSLocalizedString("DELETE_HINT", comment: "")
         return deleteButton
     }()
     private var addToPlaylistButton: UIButton = {
@@ -53,6 +58,8 @@ class EditToolbar: UIView {
         addToPlaylistButton.contentHorizontalAlignment = .left
         addToPlaylistButton.addTarget(self, action: #selector(addToPlaylist), for: .touchUpInside)
         addToPlaylistButton.tintColor = .orange
+        addToPlaylistButton.accessibilityLabel = NSLocalizedString("ADD_TO_PLAYLIST", comment: "")
+        addToPlaylistButton.accessibilityHint = NSLocalizedString("ADD_TO_PLAYLIST_HINT", comment: "")
         return addToPlaylistButton
     }()