store MLKit group identifier in Info.plist so it can be easily changed via xcconfig and even after compilation

Apple-TV/VLCTVConstants.h

@@ -13,8 +13,6 @@
 
 #define kVLCVersionCodename @"All Along the Watchtower"
 
-#define kVLCApplicationGroupIdentifier GROUP_IDENTIFIER
-
 #define kVLCRecentURLs @"recent-urls"
 #define kVLCStoreDropboxCredentials @"kVLCStoreDropboxCredentials"
 #define kVLCStoreOneDriveCredentials @"kVLCStoreOneDriveCredentials"

SharedConfig.xcconfig

@@ -18,5 +18,3 @@ BUNDLE_IDENTIFIER_PREFIX=com.example
 
 GROUP_IDENTIFIER=group.$(BUNDLE_IDENTIFIER_PREFIX).vlc-ios
 KEYCHAIN_ACCESS_GROUP=$(AppIdentifierPrefix)$(BUNDLE_IDENTIFIER_PREFIX).vlc-ios
-
-GCC_PREPROCESSOR_DEFINITIONS = "GROUP_IDENTIFIER=@\"$(GROUP_IDENTIFIER)\"";

Sources/VLC for iOS-Info.plist

@@ -243,6 +243,8 @@
 	</array>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>MLKitGroupIdentifier</key>
+	<string>$(GROUP_IDENTIFIER)</string>
 	<key>NSAppTransportSecurity</key>
 	<dict>
 		<key>NSAllowsArbitraryLoads</key>

Sources/VLCConstants.h

@@ -13,8 +13,6 @@
 
 #define kVLCVersionCodename @"All Along the Watchtower"
 
-#define kVLCApplicationGroupIdentifier GROUP_IDENTIFIER
-
 #define kVLCSettingPasscodeKey @"Passcode"
 #define kVLCSettingPasscodeOnKey @"PasscodeProtection"
 #define kVLCSettingPasscodeAllowTouchID @"AllowTouchID"

VLC WatchKit Native Extension/Info.plist

@@ -22,6 +22,8 @@
 	<string>????</string>
 	<key>CFBundleVersion</key>
 	<string>271.1</string>
+	<key>MLKitGroupIdentifier</key>
+	<string>$(GROUP_IDENTIFIER)</string>
 	<key>NSExtension</key>
 	<dict>
 		<key>NSExtensionAttributes</key>