Explorar el Código

fix crash when urlString is nil reused string variable

Felix Paul Kühne hace 9 años
padre
commit
94c2b3ce22
Se han modificado 1 ficheros con 7 adiciones y 2 borrados
  1. 7 2
      Sources/VLCMedia.m

+ 7 - 2
Sources/VLCMedia.m

@@ -822,9 +822,14 @@ NSString *const VLCMediaTracksInformationTextEncoding = @"encoding"; // NSString
     if (!p_url)
         return;
 
-    _url = [NSURL URLWithString:[[NSString stringWithUTF8String:p_url] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
+	NSString *urlString = [NSString stringWithUTF8String:p_url];
+	if (!urlString) {
+		return;
+	}
+
+    _url = [NSURL URLWithString:[urlString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
     if (!_url) /* Attempt to interpret as a file path then */ {
-        _url = [NSURL fileURLWithPath:@(p_url)];
+        _url = [NSURL fileURLWithPath:urlString];
     }
     free(p_url);