|
|
@@ -200,45 +200,42 @@ https://stackoverflow.com/questions/2331363/is-passing-a-windows-security-token-
|
|
|
## Todolist
|
|
|
|
|
|
[x] `vlc_ipc_SendIpc` must write the size of the message, then write each part
|
|
|
- of the message.
|
|
|
+of the message.
|
|
|
|
|
|
[x] `vlc_ipc_RecvMsg` must read the size of the message, then read the whole
|
|
|
- message.
|
|
|
+message.
|
|
|
|
|
|
[x] `vlc_msg_append_block` must put the name of the shared memory.
|
|
|
|
|
|
[x] `vlc_msg_recv_block` must open the shared memory and map it.
|
|
|
|
|
|
-[ ] Zygote calls `CreateProcess` with `--sandbox-worker=%file_descriptor_read`
|
|
|
- option.
|
|
|
+[ ] zygote calls `createprocess` with `--sandbox-worker=%file_descriptor_read`
|
|
|
+option.
|
|
|
|
|
|
-[ ] Zygote sends write file descriptor to new worker and then close it.
|
|
|
+[ ] zygote sends write file descriptor to new worker and then close it.
|
|
|
|
|
|
-[ ] `vlc_sandbox_Start` should start the worker eventloop if `--sandbox-worker`
|
|
|
- option is present in the command line.
|
|
|
+[ ] `vlc_sandbox_start` should start the worker eventloop if `--sandbox-worker`
|
|
|
+option is present in the command line.
|
|
|
|
|
|
-[ ] `vlc_sandbox_Start` should start the zygote if `--sandbox-zygote=%fd` is
|
|
|
- present in the command line.
|
|
|
+[ ] `vlc_sandbox_start` should start the zygote if `--sandbox-zygote=%fd` is
|
|
|
+present in the command line.
|
|
|
|
|
|
-[ ] `block_Alloc` should create a file mapping using `CreateFileMapping` and map
|
|
|
- it in memory using `MapViewOfFile`.
|
|
|
+[ ] `block_alloc` should create a file mapping using `createfilemapping` and map
|
|
|
+it in memory using `mapviewoffile`.
|
|
|
|
|
|
-[ ] `block_filemapping_Init` should use `OpenFileMapping` and `MapViewOfFile`.
|
|
|
+[ ] `block_filemapping_init` should use `openfilemapping` and `mapviewoffile`.
|
|
|
|
|
|
-[ ] `msg_poller` should use IO completion port
|
|
|
- => might work, try out
|
|
|
- => take care socket deletion
|
|
|
+[ ] `msg_poller` should use io completion port
|
|
|
+=> might work, try out
|
|
|
+=> take care socket deletion
|
|
|
|
|
|
-[ ] `vlc_ipc_Close` should close the handle, and might need to manage the
|
|
|
- allocated memory (for overlapped structure for example)
|
|
|
+[ ] `vlc_ipc_close` should close the handle, and might need to manage the
|
|
|
+allocated memory (for overlapped structure for example)
|
|
|
|
|
|
-[ ] replace `close(ipc.fd)` by `vlc_ipc_Close(ipc)`
|
|
|
+[ ] replace `close(ipc.fd)` by `vlc_ipc_close(ipc)`
|
|
|
|
|
|
[ ] try removing the zygote process from the windows model, only inherit the
|
|
|
- handle for IPC when creating a new process.
|
|
|
-
|
|
|
-[ ]
|
|
|
-
|
|
|
+handle for IPC when creating a new process.
|
|
|
|
|
|
## IOCP
|
|
|
|
|
|
@@ -326,18 +323,18 @@ https://stackoverflow.com/questions/6573218/removing-a-handle-from-a-i-o-complet
|
|
|
# Sandbox todolist
|
|
|
|
|
|
[ ] Create process by zones, all video decoders in the same process, all audio
|
|
|
- in the same other process and vout/aout in the same process as their
|
|
|
- respective counterpart
|
|
|
+in the same other process and vout/aout in the same process as their respective
|
|
|
+counterpart
|
|
|
|
|
|
[ ] Process creation policy should be in the broker process and configured at
|
|
|
- vlc_sandbox_Init by the application caller.
|
|
|
+vlc_sandbox_Init by the application caller.
|
|
|
|
|
|
[ ] Special process creation order should be possible, for example when having
|
|
|
- multiple video outputs.
|
|
|
+multiple video outputs.
|
|
|
|
|
|
[ ] Release object correctly, proxy objects should have a special released
|
|
|
- handler associated to them and be released as soon as the other endpoint
|
|
|
- is released.
|
|
|
+handler associated to them and be released as soon as the other endpoint is
|
|
|
+released.
|
|
|
|
|
|
[ ] Handle cross-process errors and report them to the other process correctly
|
|
|
|
